Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL RPC method for grpc #6731

Closed
Jhoyola opened this issue Sep 28, 2023 · 1 comment · Fixed by #7209
Closed

SQL RPC method for grpc #6731

Jhoyola opened this issue Sep 28, 2023 · 1 comment · Fixed by #7209

Comments

@Jhoyola
Copy link

Jhoyola commented Sep 28, 2023

This https://docs.corelightning.org/reference/lightning-sql is very nice. Could we have this also on the grpc api.

@ffaex
Copy link

ffaex commented Jan 19, 2024

I would love to see that supported as well. Here is my solution for now: https://github.com/ffaex/lightning/tree/feature/add_sql_rpc . But I have not tested it yet tbh. The SQL query should return a Vector of string, aka ROWs whose content is a string. One should serialize that string on his own, depending on the query.

Another thing to keep in mind is that autogenerating is not working perfectly with that, i had to modify cln-grpc/src/convert.rs manually see: "impl Fromresponses::SqlResponse for pb::SqlResponse {"

@ffaex ffaex mentioned this issue Jan 19, 2024
@ShahanaFarooqui ShahanaFarooqui linked a pull request Jun 27, 2024 that will close this issue
@ShahanaFarooqui ShahanaFarooqui added this to the v24.08 milestone Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants