Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gci: Consider adding a nightly CI workflow for reprobuilds #7117

Open
cdecker opened this issue Feb 28, 2024 · 2 comments · May be fixed by #7651
Open

gci: Consider adding a nightly CI workflow for reprobuilds #7117

cdecker opened this issue Feb 28, 2024 · 2 comments · May be fixed by #7651

Comments

@cdecker
Copy link
Member

cdecker commented Feb 28, 2024

It would be very helpful to have a nightly workflow in our
actions. This could be run over night (well, someone's night),
ensuring that the reprobuilds always work. In addition it alleviates
the problem release captains face during every release:

  1. The developer tags the release
  2. Then uploads the tag
  3. Builds the reprobuild, but during the build something got changed
  4. The version string now is something like v24.02-modded due to
    the dirty tree.

The CI could tell us ahead of time if a given reprobuild would result
in such a broken version string, and we would be able to always
cross-check the reprobuilds, avoiding accidental back and forth during
the release.

@BitcoinJiuJitsu
Copy link

@s373nZ s373nZ linked a pull request Sep 7, 2024 that will close this issue
4 tasks
@s373nZ
Copy link
Contributor

s373nZ commented Sep 7, 2024

@BitcoinJiuJitsu I just submitted PR #7651 in hopes of winning this bounty. Please feel free to assign to me.

s373nZ added a commit to s373nZ/lightning that referenced this issue Sep 17, 2024
s373nZ added a commit to s373nZ/lightning that referenced this issue Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants