Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-experimentalize DNS Bolt7 #911 ? #5756

Closed
wants to merge 1 commit into from

Conversation

m-schmoock
Copy link
Collaborator

@m-schmoock m-schmoock commented Nov 30, 2022

Most mainnet implementations are still broken when it comes to propagate node_announcent that have IP/Tor and also DNS names in them.

They should propagate entries they do not understand, but instead they drop it.
Having this feature live would make nodes inaccessible that try to use DNS.
We need to re-evaluate this in a couple of month.

Alternatives:

  • keep it as is in order to gently push the other implementations. I think the blame will be on us anyway.
  • disable DNS announcements but add static old style IP entries if DNS is used by config

This PR is just to have a brief discussion about this issue before release...

…RIMENTAL

Most mainnet implementations are still broken when it comes to propagate
`node_announcent` that have IP/Tor and also DNS names in them.

They should propagate entries entries they do not understand, but
instead they drop it.

Having this feature live would make nodes inaccessible that try to use
DNS.

We need to re-evaluate this in a couple of month.

Changelog-None
@cdecker
Copy link
Member

cdecker commented Nov 30, 2022

I think making this experimental again is likely the wrong thing to do, as it reduces pressure on other implementations to fix this, and pressure on node operators running old versions that were dropping messages wrongly. By rolling it out now, should incentivize implementors and operators to fix this. It's not something we can do on our own, but we can create an issue, pointing to implementation-specific tickets to address it, and pin it in our issue tracker. That should make it clear that the issue is on others to fix.

@m-schmoock
Copy link
Collaborator Author

m-schmoock commented Nov 30, 2022

F.y.i. Acinq has interop with this feature ( ACINQ/eclair#2234 ) and rust-lightning ( lightningdevkit/rust-lightning#1553 ) implemented it, not sure if they did interop, but lets assume yes.

@m-schmoock m-schmoock changed the title Re-experimentalize DNS Bolt7 #911 Re-experimentalize DNS Bolt7 #911 ? Nov 30, 2022
@m-schmoock
Copy link
Collaborator Author

m-schmoock commented Nov 30, 2022

Fun fact, there are currently 4 nodes trying to use this... likely because its still experimental.
Its likely more nodes, but I can't see all of them because of the propagation issues.

lnc listnodes | grep -A 2 '"dns"' 
               "type": "dns",
               "address": "de2.tunnelsats.com",
               "port": 18631
--
               "type": "dns",
               "address": "orangenight.dynv6.net",
               "port": 9735
--
               "type": "dns",
               "address": "de1.tunnelsats.com",
               "port": 12303
--
               "type": "dns",
               "address": "lninsights.airdns.org",
               "port": 42495

@m-schmoock m-schmoock closed this Dec 1, 2022
@m-schmoock
Copy link
Collaborator Author

Discussion now obsolete, 22.11 is released :)

@m-schmoock m-schmoock deleted the disable-dns branch December 5, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants