cln_plugin : Support wildcard subscriptions
#7106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is also useful to support sending notifications over GRPC. (See #7084) For this plug-in it is useful to subscribe to all notifications. |
ErikDeSmedt
force-pushed
the
rust_subscribe_wildcard
branch
from
7e0ee1f
to
ebf67c8
Compare
rustyrussell
requested changes
Mar 25, 2024
Creates an example package that subscribes to all notifications and logs them. This is useful for testing the behavior of subscribing to "*". I've also edited the Makefile to ensure that `make` builds the example and that `make clean` removes the example
This test reproduces a bug in the `cln-plugin`-crate. Core Lightning supports a wildcard `*` that plugins can use to subscribe to all notifications. However, `cln-plugin` does not support this case. It allows the developer to subscribe `*`. But the plug-in crashes when the first notification is received
Adapts `cln_plugin` to make it support wildcard `*`-subscriptions.
ErikDeSmedt
force-pushed
the
rust_subscribe_wildcard
branch
from
ebf67c8
to
e32e654
Compare
|
I think the issues addressed by @rustyrussell have been fixed. |
cdecker
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Core Lightning plugins can subscribe to notifications using a wildcard
*.When the wildcard is used the plugin will receive all notifications.
This behavior was not supported by
cln_plugin.The first 2 commits create a plug-in that listens to the the wildcard
*-subscriptionand test the behavior. It appears that
cln_pluginaccepts the subscription but fails when the first plug-in messageis received.
The last commit adapts the
cln_plugin-crate to support the wildcard.