Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msggen: add commando, commando-rune, commando-listrunes, commando-blacklist methods #7269

Closed
wants to merge 1 commit into from

Conversation

daywalker90
Copy link
Contributor

this adds:

  • commando
  • commando-rune
  • commando-listrunes
  • commando-blacklist

But they are incomplete. Missing fields because of OneOf complexity in the schemas:

  • Commando.params, unsure what do here since object can't know what fields it will have and array would require all positional args to be present if i understand this correctly
  • CommandoResponse how to define the response of this command?
  • Commando-rune.restrictions is either a string or an array of an array of strings. Can this be simplified to just an array of strings?

@rustyrussell
Copy link
Contributor

These are deprecated except for commando itself.

Commando is recursive, though, which makes this difficult to define!

@ShahanaFarooqui
Copy link
Collaborator

Closing in favour of PR #7209.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants