-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins/grpc: default value for grpc port #7479
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 9127f94
9127f94
to
c4915d3
Compare
The change in the behavior appears to cause the |
217a378
to
e4bce57
Compare
The test is starting two nodes and both are now trying to use the default port 9736 for the cln-grpc plugin which is causing one of them to crash |
ec5a53c
to
a2f3b0e
Compare
6285509
to
957a999
Compare
So, when people upgrade they will have a new random port open to the internet? I know @michael1011 wants this, but would it be sufficient to open a localhost-bound port by default in this case? |
6d5238c
to
cd133a2
Compare
Not related to this PR.
7a64585
to
faa814e
Compare
@rustyrussell that's a very valid point. What about adding an option to configure the host on which the plugin will listen and defaulting that to Edit: I can't think of any other sensible option, so let's do that. The only concern is that it's a breaking change for all existing CLNs that have a gRPC port configured and expect the plugin to listen on |
374ab49
to
c6dc9a6
Compare
Changelog-Changed: grpc now starts on port 9736 by default
A port should not be opened by default on 0.0.0.0, so change the default to localhost Changelog-Added: `grpc-host` option for grpc plugin
plugin seems to cause issues in combination with the test `misc_notifications.py` plugin
c6dc9a6
to
3f88c90
Compare
The gRPC server will always start this way. Current port choice is arbitrary, open to suggestions.
closes: #7473