Add extra configuration options to gRPC #7672
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikDeSmedt
force-pushed
the
configure-grpc
branch
2 times, most recently
from
9495028
to
ce51306
Compare
A small refactor that allows to specify a more flexible configuration in the grpc-plugin. Changelog: By default the grpc-plugin will bind to 127.0.0.1 instead of 0.0.0.0
Changelog: Introduce the grpc-ip-address option to configure the IP on which the grpc-plugin will listen.
Also support using the cln-grpc plugin over http. This is useful for testing. As a safe-guard we only allow this configuration if the services binds to the loopback address.
ErikDeSmedt
force-pushed
the
configure-grpc
branch
from
ce51306
to
05e01e0
Compare
ErikDeSmedt
force-pushed
the
configure-grpc
branch
from
05e01e0
to
025bfc4
Compare
|
The I tried to reproduce the failure locally. Subsequently, I ran the test a 100 times. I haven't observed a single failure. I'm not convinced the test is actually broken and don't have a way to reproduce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Title
Description
I've added a few configuration options to the gRPC-plugin.
grpc-ip-address: I've changed the default ip-address to which the gRPC interface will bind from0.0.0.0to127.0.0.1. This new default should be more secure. Users who need to access the gRPC-interface externally can setgrpc-ip-addressto the port they like. Users can also configure an IPv6 address.grpc-scheme: Previously, the gRPC connection only allowed https over mTLS. Configurting mTLS is somewhat cumbersome. Users that only need the gRPC interface locally can now setgrpc-scheme=http. This will only work ifgrpc-ip-addressis set to a loopback address (127.0.0.1 or equivalent for IPv6).Related Issues
cln-grpc: Specify a host and port #7654Changes Made
Checklist
Ensure the following tasks are completed before submitting the PR:
TODOshave been addressed or removed.Additional Notes
Any additional information or context about this PR that reviewers should know.