pytests: further extend the offline mode testcase #7676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-schmoock
force-pushed
the
fix/offline_mode
branch
from
1f86a5e
to
3a4a185
Compare
| assert not l1.daemon.is_in_log("connectd: Created listener on") | ||
| # and not to allow connections | ||
| assert not l1.rpc.connect(l2.info['id'], 'localhost', l2.port) |
There was a problem hiding this comment.
we are not an rpc error here?
There was a problem hiding this comment.
Yeah likely correct, I'll fix that line on the test, when cln refuses to make connections with offline nodes so I can check for the actual error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just more on the xfail testcase
Now the testscase reflects what I would expect from an
--offlinenode: