Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AraDICE task config file #2507

Merged
merged 21 commits into from
Dec 24, 2024
Merged

AraDICE task config file #2507

merged 21 commits into from
Dec 24, 2024

Conversation

firojalam
Copy link
Contributor

The AraDICE task and associated config files are based on the following paper.
https://arxiv.org/abs/2409.11404

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2024

CLA assistant check
All committers have signed the CLA.

@firojalam
Copy link
Contributor Author

@baberabb @lintangsutawika,
Can you please consider merging the pull request?

Thanks

@baberabb
Copy link
Contributor

@firojalam LGTM! One last thing: could you add an entry to lm_eval/tasks/README.md explaining the task in one sentence like all the other tasks? Thanks!

@firojalam
Copy link
Contributor Author

@baberabb, thanks.
Added task information as advised.

@baberabb
Copy link
Contributor

For multiple-choice tasks the default prompt format is <doc_to_text><target_delimiter><doc_to_choice> for each choice in doc_to_choice, where the default target_delimiter=" "
Some tasks failing a check where doc_to_choice starts with a space and target delimiter is also a space. Just wanted to confirm if that is the your expected format.

@firojalam
Copy link
Contributor Author

@baberabb , We did have a fix. Can you please check? Thanks

@firojalam
Copy link
Contributor Author

Hi @baberabb , sorry that this is taking time.
We fixed the formatting issue. Can you please check if it is fine now?
Thanks

@firojalam
Copy link
Contributor Author

@baberabb , can you please advise whether we need to do anything? Looks like it is still failing. We do not find any issue on the local test.

@baberabb
Copy link
Contributor

@baberabb , can you please advise whether we need to do anything? Looks like it is still failing. We do not find any issue on the local test.

Sorry, the failing test is unreleated. Looks good to merge! Thanks for the PR.

@baberabb baberabb merged commit 932e8f9 into EleutherAI:main Dec 24, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants