Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(discussion): make it much easier for guests to post new topics #28

Merged
merged 2 commits into from
Apr 30, 2014

Conversation

ewinslow
Copy link
Contributor

  • "Add discussion topic" button always visible, even when logged out.
  • Target group can be selected via autocomplete
  • Auto-join to selected group if possible and not already a member

Refs #14

 * "Add discussion topic" always visible, even when logged out.
 * Group can be selected via autocomplete
 * Auto-join to selected group if possible and not already a member

Refs #14
@ewinslow ewinslow changed the title feature(discussion): make it 10x easier for guests to post new topics feature(discussion): make it much easier for guests to post new topics Apr 19, 2014
@ewinslow
Copy link
Contributor Author

@Elgg/team-elgg thoughts on this?

@brettp
Copy link
Member

brettp commented Apr 19, 2014

Like the idea, but I think it'd be better to use a select input for group selection. A newbie doesn't know which groups are available, and if we hand-pick the groups to display we can funnel people into some of the more popular (and usually more appropriate) groups.

@ewinslow
Copy link
Contributor Author

We could just list the features groups then, maybe?

@brettp
Copy link
Member

brettp commented Apr 19, 2014

Yes, good idea.

@ewinslow
Copy link
Contributor Author

OK I decided to use <datalist> for this. It doesn't work in all browsers (about 25% of our visits to the community, according to analytics) but I think is a good compromise that shows initial suggestions but also doesn't limit you to those if you know what group you're looking for. That number also will naturally go down over time as browsers are mostly auto-upgrading these days.

@ewinslow
Copy link
Contributor Author

Pulling this in as no further objections in a couple weeks.

ewinslow added a commit that referenced this pull request Apr 30, 2014
feature(discussion): make it much easier for guests to post new topics
@ewinslow ewinslow merged commit 3cd0a52 into master Apr 30, 2014
@ewinslow ewinslow deleted the discussion-14 branch April 30, 2014 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants