Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show larger images on themes pages #55

Open
ewinslow opened this issue Apr 22, 2014 · 6 comments
Open

Show larger images on themes pages #55

ewinslow opened this issue Apr 22, 2014 · 6 comments

Comments

@ewinslow
Copy link
Contributor

Want themes to be more pretty. More picture-centric in general

@ewinslow ewinslow changed the title Give theme plugins option to upload background image Show larger images on themes pages Apr 22, 2014
@hypeJunction
Copy link
Contributor

Speaking from experience, working with images in Elgg is a bit of a torture. We will need an API for managing uploads, storing them in the filestore, rendering them client side. For every image or icon, we now have to take the following steps:

  1. Create a file input that can handle single or multiple file uploads of type image
  2. Handle uploads (have to copy/paste every time), filter out non-image files
  3. Figure out where to store these images on the filestore (I always forget and have too look in the upload action to remember the structure that was used)
  4. Write a custom page handler
  5. Write a hook to replace the entity icon url

Not to mention all the trouble with hard-coded icon sizes, global sizes config that can not be filtered via hooks, no image manipulation library etc.

Additionally, I do not think that picture-centric is necessary pretty. Content intensive sites might not care as much about images, and vice-versa having a 200x200 avatar in a summary view that has no description might look ugly.

@ewinslow
Copy link
Contributor Author

Man, agreed big time. Definitely need a better image solution.

Find the issue on elgg/elgg and let's continue discussing there

@ewinslow
Copy link
Contributor Author

The purpose of themes, though, is the look. It should be really easy to tell if a theme has the look in going for. Best way to do that is with pictures.

@PerJensen
Copy link
Contributor

I worked on community changes a while ago and this is one of my mock ups.

Besides the larger preview image content is seperated into description, support (comments) and gallery. Buttons moved to sidebar and list of releases as select dropdown.

themes-profile

@ewinslow
Copy link
Contributor Author

I was thinking something more like the image is the full width of the main
column.

Do you have thoughts about how this should look on mobile?
On Apr 22, 2014 10:22 PM, "Per Jensen" notifications@github.com wrote:

I worked on community changes a while ago and this is one of my mock ups.

Besides the larger preview image content is seperated into description,
support (comments) and gallery. Buttons moved to sidebar and list of
releases as select dropdown.

[image: themes-profile]https://cloud.githubusercontent.com/assets/1220345/2773819/1591203c-caa7-11e3-8f8f-699f978f59ea.jpg


Reply to this email directly or view it on GitHubhttps://github.com//issues/55#issuecomment-41125799
.

@PerJensen
Copy link
Contributor

Yes, I imagine that on the new gallery tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants