Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes crafting ingredients don't fully arrive for some reason #235

Open
Ellpeck opened this issue Dec 5, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@Ellpeck
Copy link
Owner

Ellpeck commented Dec 5, 2024

I've only seen this happen consistently with the EnderIO crafter and specifically the pipe crafting recipe, where a second iron bar never arrives, so far. This only happens in the "per craft" and "all" insertion modes.

  • Idea 1: I haven't managed to find a clear reason for this, but I assume it has something to do with the fact that, out of the many recipes I've tried, both pipes (the output) and iron bars (one of the inputs) are (one of) the only ones that have a high output amount - so maybe something gets confused there when calculating how many inputs are actually needed?
  • Idea 2: Because the insertion mode that it doesn't happen with only differs in a travelingIngredients.isEmpty() check, maybe the traveling ingredients collection gets confused somehow?
  • Idea 3: in store, getTravelingIngredient is used to shrink the traveling ingredient of the given type, but only a single traveling ingredient is ever compared against. Since the issue only happens with a second iron bar being delivered in the recipe, maybe the same iron bar ingredient gets deducted twice somehow or something
@Ellpeck Ellpeck added the bug Something isn't working label Dec 5, 2024
@Ellpeck
Copy link
Owner Author

Ellpeck commented Dec 5, 2024

Reproduced this with multiple recipes, and it's always specifically the last item in a set of the same item missing (like when four redstone should be sent, it's 3 instead, etc.), and it's always fixable by switching to singles mode! I'm still not sure what exactly causes it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant