Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2025 monthly badges tweaks #206

Merged
merged 3 commits into from
Jan 6, 2025
Merged

2025 monthly badges tweaks #206

merged 3 commits into from
Jan 6, 2025
+16 −4

Conversation

ilicfilip
Copy link
Collaborator

Context

This PR fixes 2 things:

  • We have scrollable widget for monthly badges. Because we show only 6 badges per scroll it's height needs to be set dynamically on page load, but that needed to be adjusted to wait explicitly for all images to load since we switched to remote images.
  • Second commit fixes the 2026 badges being displayed for users who activated in 2024.

Summary

This PR can be summarized in the following changelog entry:

  • Scrollable monthly badges widget height on page load.
  • 2026 monthly badges showing up

Quality assurance

  • I have tested this code to the best of my abilities.
  • I have added unit tests to verify the code works as intended.
  • I have checked that the base branch is correctly set.

@ilicfilip ilicfilip requested a review from aristath January 3, 2025 06:42
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025 •
edited
Loading

Test on Playground
Test this pull request on the Playground or download the zip.

@jdevalk jdevalk merged commit c126f9d into develop Jan 6, 2025
17 checks passed
@jdevalk jdevalk deleted the filip/fix-new-year-badges branch January 6, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdevalk jdevalk jdevalk approved these changes

@aristath aristath Awaiting requested review from aristath

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilicfilip @jdevalk