Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading Aurora to AiiDA 2.x #26

Merged
merged 9 commits into from
Aug 24, 2023
Merged

Upgrading Aurora to AiiDA 2.x #26

merged 9 commits into from
Aug 24, 2023

Conversation

edan-bainglass
Copy link
Collaborator

  • Plugin now dependent on aiida_ssh2win transport plugin
  • Scheduler now dependent on transport shell type (hardcoded in aiida_ssh2win)
  • Transport also takes care of recent encoding issues
  • Example config files updated for AiiDA 2.x

@edan-bainglass edan-bainglass mentioned this pull request Aug 19, 2023
Merged
@edan-bainglass edan-bainglass mentioned this pull request Aug 23, 2023
Merged
ramirezfranciscof
ramirezfranciscof approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@ramirezfranciscof ramirezfranciscof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Maybe open an issue to update to Pydantic 2.0

@edan-bainglass edan-bainglass merged commit 5dc20f1 into EmpaEconversion:main Aug 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramirezfranciscof ramirezfranciscof ramirezfranciscof approved these changes

@lorisercole lorisercole Awaiting requested review from lorisercole

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edan-bainglass @ramirezfranciscof