-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: nav bar with search bar #4
Conversation
π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great.
I checked the ticket requirements and reviewed the new layout and SCSS changes.
The navbar with search button works well in every responsive breakpoint I tried, and tabbing between elements did what I expected when the search form was open or closed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The one thing that I'm noticing is that it's not working properly with VoiceOver. It'd be nice to fix that if it's easy, but the nav as a whole is not accessible (and will hopefully be rewritten fully soon), so I'm not too worried about getting this perfect.
π Linked issue
https://energysage.atlassian.net/browse/CED-1940
β Type of change
π Description
Add a search bar and documentation that uses the design of the MVP and fulfills these requirements:
fill: blue-600
while the dropdown is openπ₯Ό Testing
π§ Feedback Requested / Focus Areas
π Checklist