fix(todos): add ids to response models and query filter

EnisMulic · Nov 17, 2023 · 8b01b58 · 8b01b58
1 parent 9d57c3d
commit 8b01b58
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 13 deletions.
diff --git a/src/Application/Features/Todos/CompleteTodoItem.cs b/src/Application/Features/Todos/CompleteTodoItem.cs
@@ -49,13 +49,11 @@ public async Task<Unit> Handle(CompleteTodoCommand request, CancellationToken ca
         var item = await _context.TodoItems.FindAsync(new object?[] { request.Id }, cancellationToken: cancellationToken)
             ?? throw new NotFoundException(nameof(TodoItem), request.Id);
 
-        //if (!item.Done)
-        //{
-
-        //}
-
-        item.Complete();
-        await _context.SaveChangesAsync(cancellationToken);
+        if (!item.Done)
+        {
+            item.Complete();
+            await _context.SaveChangesAsync(cancellationToken);
+        }
 
         return Unit.Value;
     }

diff --git a/src/Application/Features/Todos/GetTodos.cs b/src/Application/Features/Todos/GetTodos.cs
@@ -25,7 +25,7 @@ public void AddRoutes(IEndpointRouteBuilder app)
             return response;
         })
         .RequireAuthorization()
-        .Produces<int>(StatusCodes.Status201Created)
+        .Produces<List<TodoListResponse>>(StatusCodes.Status200OK)
         .Produces(StatusCodes.Status400BadRequest)
         .WithOpenApi(operation => new(operation)
         {

diff --git a/src/Application/Features/Todos/TodoListResponse.cs b/src/Application/Features/Todos/TodoListResponse.cs
@@ -7,16 +7,18 @@ namespace Application.Features.Todos;
 #nullable disable
 public class TodoListResponse : IMapFrom<TodoList>
 {
+    public int Id { get; set; }
     public string Title { get; set; }
     public string Colour { get; set; }
     public IList<TodoItemResponse> Items { get; set; }
 }
 
 public class TodoItemResponse : IMapFrom<TodoItem>
 {
-    public string Title { get; private set; }
-    public string Note { get; private set; }
-    public PriorityLevel PriorityLevel { get; private set; }
-    public bool Done { get; private set; }
-    public DateTime? Reminder { get; private set; }
+    public int Id { get; set; }
+    public string Title { get; set; }
+    public string Note { get; set; }
+    public PriorityLevel PriorityLevel { get; set; }
+    public bool Done { get; set; }
+    public DateTime? Reminder { get; set; }
 }
diff --git a/src/Application/Infrastructure/Persistance/Configurations/TodoItemConfiguration.cs b/src/Application/Infrastructure/Persistance/Configurations/TodoItemConfiguration.cs
@@ -9,6 +9,8 @@ public class TodoItemConfiguration : IEntityTypeConfiguration<TodoItem>
 {
     public void Configure(EntityTypeBuilder<TodoItem> builder)
     {
+        builder.HasQueryFilter(i => !i.IsDeleted);
+
         builder.Property(t => t.Title)
             .HasMaxLength(200)
             .IsRequired();