Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goodjooy
approved these changes
Nov 8, 2024
Goodjooy
requested changes
Nov 19, 2024
libs/bitmap-convert/src/base70.rs
Outdated
Comment on lines
8
to
23
| const BASE_70: &str = | ||
| "0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ-~._()!*"; | ||
| // 字符转下标 | ||
| static CHAR_TO_INDEX: LazyLock<[u8; 127]> = LazyLock::new(|| { | ||
| let mut char_to_index: [u8; 127] = [0; 127]; | ||
| let index_to_char = BASE_70.chars().collect::<Vec<char>>(); | ||
| for (i, c) in index_to_char.iter().enumerate() { | ||
| char_to_index[*c as usize] = i as u8; | ||
| } | ||
| char_to_index | ||
| }); | ||
| // 下标转字符 | ||
| static INDEX_TO_CHAR: LazyLock<Vec<char>> = | ||
| LazyLock::new(|| BASE_70.chars().collect()); | ||
| // 字符数量 | ||
| static RADIX: LazyLock<u32> = LazyLock::new(|| INDEX_TO_CHAR.len() as u32); |
There was a problem hiding this comment.
- 为何不将
BASE_70改成b"0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ-~._()!*",这样类型就是&'static [u8] - 为何这边迭代器需要先 collect 到Vec 然后再转迭代器再加enumerate?
- 此外，使用enum来从0 开始写入，为何不能是 将
char_to_index取iter_mut, 然后和index_to_char取zip
libs/bitmap-convert/src/base70.rs
Outdated
Comment on lines
8
to
23
| const BASE_70: &str = | ||
| "0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ-~._()!*"; | ||
| // 字符转下标 | ||
| static CHAR_TO_INDEX: LazyLock<[u8; 127]> = LazyLock::new(|| { | ||
| let mut char_to_index: [u8; 127] = [0; 127]; | ||
| let index_to_char = BASE_70.chars().collect::<Vec<char>>(); | ||
| for (i, c) in index_to_char.iter().enumerate() { | ||
| char_to_index[*c as usize] = i as u8; | ||
| } | ||
| char_to_index | ||
| }); | ||
| // 下标转字符 | ||
| static INDEX_TO_CHAR: LazyLock<Vec<char>> = | ||
| LazyLock::new(|| BASE_70.chars().collect()); | ||
| // 字符数量 | ||
| static RADIX: LazyLock<u32> = LazyLock::new(|| INDEX_TO_CHAR.len() as u32); |
There was a problem hiding this comment.
- 为何不将
BASE_70改成b"0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ-~._()!*",这样类型就是&'static [u8] - 为何这边迭代器需要先 collect 到Vec 然后再转迭代器再加enumerate?
- 此外，使用enum来从0 开始写入，为何不能是 将
char_to_index取iter_mut, 然后和index_to_char取zip
Goodjooy
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.