Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mbarba/match synonym #372

Merged
merged 4 commits into from
May 22, 2024
Merged

Mbarba/match synonym #372

merged 4 commits into from
May 22, 2024

Conversation

MatBarba
Copy link
Contributor

We're matching functional_annotation ID to the core stable_id, and we've recently also added a match from the xrefs.
This PR adds a match to the synonyms as well (this improves the matching to transfer descriptions and xrefs from an older core).

  • Also make the match case insensitive
  • Rewrite the code to make it a bit clearer

@MatBarba MatBarba self-assigned this May 22, 2024
Copy link
Contributor

@JAlvarezJarreta JAlvarezJarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactor looks sensible. Just a tiny change but good otherwise.

src/python/ensembl/io/genomio/annotation/load.py Outdated Show resolved Hide resolved
MatBarba and others added 2 commits May 22, 2024 12:37
Co-authored-by: J. Alvarez-Jarreta <jalvarez@ebi.ac.uk>
@MatBarba MatBarba merged commit 48dce37 into main May 22, 2024
@MatBarba MatBarba deleted the mbarba/match_synonym branch May 22, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants