-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HCBS Footer 2/x - Set up app routes #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any glaring problems so far. I'd really love to be able to get by without importing date-fns
or moment
, but solving for that doesn't need to be a blocker for the Footer story.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double checking: Do we need the LoginCognito
and LoginIDM
for this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you merge the other Footer PR, will this testId get added back?
see last comment! |
Code Climate has analyzed commit 7853cca and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 64.3% (90% is the threshold). This pull request will bring the total coverage in the repository to 81.0% (-9.7% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Description
Related ticket(s)
CMDCT-
How to test
Click the Contact us link in the footer and confirm it goes to our help page.
Follow up PRs will include: (potentially) re-organizing some of our styles and setting up similar routes for the Header
Important updates
Author checklist
convert to a different template: test → val | val → prod