Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCBS Footer 2/x - Set up app routes #13

Merged
merged 14 commits into from
Jul 31, 2024
Merged

HCBS Footer 2/x - Set up app routes #13

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3e107db
footer progress
ajaitasaini Jul 24, 2024
6f92353
wip
ajaitasaini Jul 26, 2024
51c8c28
adding all the relevant imports
ajaitasaini Jul 26, 2024
734ee78
fixed routing
ajaitasaini Jul 29, 2024
9ad14e8
removed unnecessary changes
ajaitasaini Jul 29, 2024
89808d8
add todo comment back in
ajaitasaini Jul 29, 2024
e2361e0
merged with previous branch
ajaitasaini Jul 29, 2024
499e412
fixed unit test
ajaitasaini Jul 29, 2024
29b45ce
nits
ajaitasaini Jul 30, 2024
fe6b3a1
nits
ajaitasaini Jul 30, 2024
8658f81
nit
ajaitasaini Jul 30, 2024
7c69484
remove extra test id
ajaitasaini Jul 30, 2024
67c0986
Merge remote-tracking branch 'origin/main' into footer-2
ajaitasaini Jul 30, 2024
7853cca
merge conflicts
ajaitasaini Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions services/ui-src/src/components/app/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export const App = () => {
const { user, showLocalLogins } = useStore();
// const { pathname } = useLocation();

// TODO: fire tealium page view on route change
// TODO: fire tealium page view on route change
/*
* useEffect(() => {
* fireTealiumPageView(
Expand All @@ -34,7 +34,7 @@ export const App = () => {
const authenticatedRoutes = (
<>
{user && (
<Flex data-testid="app-container" sx={sx.appLayout}>
<Flex sx={sx.appLayout}>
ajaitasaini marked this conversation as resolved.
Show resolved Hide resolved
<Timeout />
<Container sx={sx.appContainer} data-testid="app-container">
<ErrorBoundary FallbackComponent={Error}>
Expand Down