Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Banners #61

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Display Banners #61

merged 2 commits into from
Nov 26, 2024

Conversation

ailZhou
Copy link
Collaborator

@ailZhou ailZhou commented Nov 25, 2024

Description

This PR adds the code for displaying the banner to the home page for any state user and non state user.

Related ticket(s)

CMDCT-4091


How to test

Deploy Link: https://d19jc7bal1zoty.cloudfront.net/

Generate a banner to be displayed
Follow the steps here to generate a banner. Make sure the start and end date encompasses the current date.

View the Banner

  1. Once the banner is generated, if you go back to the homepage of the admin user, you should see it.
    Screenshot 2024-11-25 at 3 42 58 PM

  2. Sign out and sign back in as a state user, any user. Once logged in, you should see the banner at the top of the page.
    Screenshot 2024-11-25 at 3 43 21 PM

Important updates


Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

convert to a different template: test → val | val → prod

@ailZhou ailZhou added the draft Just a draft label Nov 25, 2024
@ailZhou ailZhou marked this pull request as ready for review November 25, 2024 20:43
@ailZhou ailZhou added ready for review Ready for all the reviews! and removed draft Just a draft labels Nov 25, 2024
Copy link
Contributor

@ajaitasaini ajaitasaini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested via cloudfront link + code looks good to me!

@ailZhou ailZhou merged commit ddb5b0f into main Nov 26, 2024
19 checks passed
@ailZhou ailZhou deleted the cmdct-4091-disp-ban branch November 26, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants