Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QMS - LTSS-1 - Measure Overview Page #66

Merged
merged 19 commits into from
Dec 5, 2024
Merged

QMS - LTSS-1 - Measure Overview Page #66

merged 19 commits into from
Dec 5, 2024

Conversation

ailZhou
Copy link
Collaborator

@ailZhou ailZhou commented Dec 2, 2024

Description

This PR builds out LTSS-1 measure overview page. The content of what's suppose to be on this page is written in the jira ticket, the figma is just for a general idea of what the page might look like,

I also expanded the radio button to have children elements underneath.
Screenshot 2024-12-03 at 3 52 55 PM

Note

  1. Children textboxes of the radio button currently does not save any data. Will address in a separate PR.
  2. The quality measure table [Edit] buttons do not go anywhere yet. Also will address in a separate PR.

Related ticket(s)

CMDCT-4139


How to test

  1. Sign into HCBS, any state user
  2. Create a QM report
  3. On the sidebar menu, select [Required Measure Results]. You should see a row for CMIT # 960.
    • The generation for this table is covered by another ticket.
  4. Click [Edit] and you be taken to the LTSS-1 measure overview page.
  5. Check that the questions matches what is written in the jira ticket: CMDCT-4139.
  6. You should see a page that looks like this
    localhost_3000_report_QM_PR_2pir7juQ4TtESKqww3nP30icY6A

Important updates


Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

convert to a different template: test → val | val → prod

@ailZhou ailZhou added the in progress In progress label Dec 2, 2024
@ailZhou ailZhou removed the in progress In progress label Dec 3, 2024
@ailZhou ailZhou marked this pull request as ready for review December 4, 2024 19:54
@ailZhou ailZhou added the ready for review Ready for all the reviews! label Dec 4, 2024
Copy link

codeclimate bot commented Dec 4, 2024

Code Climate has analyzed commit 434f6e9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 97.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 94.6% (1.2% change).

View more on Code Climate.

Copy link
Contributor

@angelaco11 angelaco11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for working with me on this. I tested your changes on cloudfront and the measure details are as expected.

@ailZhou ailZhou merged commit afb4423 into main Dec 5, 2024
17 checks passed
@ailZhou ailZhou deleted the cmdct-4139-ltss-1 branch December 5, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants