Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QMS - LTSS-6, LTSS-7, LTSS-8 - Measure Overview Page #76

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Conversation

ajaitasaini
Copy link
Contributor

@ajaitasaini ajaitasaini commented Dec 11, 2024

Description

This PR adds the content for the LTSS-6, LTSS- 7, LTSS-8 measure overview page. The content of what's suppose to be on this page is written in the Jira ticket, the Figma is just for a general idea of what the page might look like

Notes from LTSS-3:
"I propose, holding off on the edit button going to a blank page at least until the routing by page id PR is merged in, so there's consistency with how we're routing."

Notes from LTSS-1:
"Children textboxes of the radio button currently does not save any data. Address in a separate PR."
"The quality measure table [Edit] buttons do not go anywhere yet. Address in a separate PR."

Related ticket(s)

CMDCT-4149, CMDCT-4151, CMDCT-4153


How to test

Sign into HCBS, any state user: https://d1n5pfglnxp0wk.cloudfront.net/
Create a QM report
On the sidebar menu, select [Required Measure Results]. You should see a row for CMIT # 20.
The generation for this table is covered by another ticket.
Click [Edit] and you be taken to the LTSS-6 measure overview page.
Check that the questions matches what is written in the jira ticket: CMDCT-4141.
You should see a page that looks like this:
Screenshot 2024-12-11 at 2 08 45 PM

Repeat steps for LTSS-7 (you should see the same questions/page but with CMIT # 968
Repeat steps for LTSS-8 (you should see the same questions/page but with CMIT # 414

Important updates


Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

convert to a different template: test → val | val → prod

@ajaitasaini ajaitasaini changed the title ltss6 and 7 QMS - LTSS-6 - Measure Overview Page Dec 11, 2024
@ajaitasaini ajaitasaini marked this pull request as ready for review December 11, 2024 15:35
@ajaitasaini ajaitasaini marked this pull request as draft December 11, 2024 15:43
@ajaitasaini ajaitasaini changed the title QMS - LTSS-6 - Measure Overview Page QMS - LTSS-6, LTSS-7, LTSS-8 - Measure Overview Page Dec 11, 2024
@ajaitasaini ajaitasaini marked this pull request as ready for review December 11, 2024 18:10
BearHanded
BearHanded previously approved these changes Dec 11, 2024
Copy link
Contributor

@rocio-desantiago rocio-desantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the question: "What Technical Specifications are you using to report this measure?"
That one only applies to LTSS-1, LTSS-2, LTSS-3, LTSS-4 Measures

Copy link
Contributor

@rocio-desantiago rocio-desantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From this excel sheet - that should have been on the ticket lol
measure spec is only CMS for all 3, delivery system still has both MLTSS and FSS and Administrative instead of Hybrid Data source

Copy link

codeclimate bot commented Dec 11, 2024

Code Climate has analyzed commit 8d5bd81 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 94.1% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@rocio-desantiago rocio-desantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ajaitasaini ajaitasaini added the ready for review Ready for all the reviews! label Dec 12, 2024
Copy link
Contributor

@angelaco11 angelaco11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ajaitasaini ajaitasaini merged commit 046c7fb into main Dec 12, 2024
19 checks passed
@ajaitasaini ajaitasaini deleted the ltss-6 branch December 12, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants