Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HCBS] QMS - FASI-1, FASI-2, HCBS-10 optional measures #82

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

rocio-desantiago
Copy link
Contributor

@rocio-desantiago rocio-desantiago commented Dec 16, 2024

Description

  • MeasurePage tentatively updated to match changes from PR [HCBS] QMS - Set CMIT Number & Add QM to LTSS-5 #80
  • Some typos addressed
  • CMIT files reorganize to be consistent with order of required measures followed by optional measures similar to qm.ts file.
  • CMIT files updated to reflect measure details from this excel sheet
    • Such as
      Measure CMIT Measure Specs Delivery System Data Source
      FASI-1 969 CMS MTLSS, FFS Record Review
      FASI-2 970 CMS MTLSS, FFS Record Review
      HCBS-10 111 CMS MTLSS Case Management Records
  • Record Review added as a DataSource option
    • Added for the time being until we hear otherwise:
      Screenshot of comment on Data Source column in excel sheet of Measures

Related ticket(s)

CMDCT-4155 (FASI-1)
CMDCT-4157 (FASI-2)
CMDCT-4159 (HCBS-10)


How to test

Cloudfront URL: https://d1m8ad8ivtkepf.cloudfront.net/

  1. Sign into HCBS, any state user
  2. Create a QM report
  3. On the sidebar menu, select [Optional Measure Results].
    • The 1st row - FASI-1, CMIT #969
    • The 2nd row - LTSS-5, CMIT #970
    • The 3rd row - LTSS-5, CMIT #111
  4. Click [Edit] and you be taken to each respective measure overview page.
  5. Check that the questions matches what is written in the jira tickets: CMDCT-4155 , CMDCT-4155 , CMDCT-4159
  6. For FASI-1, you will see this page
    FASI-1 Measure Overview Page
  7. For FASI-2, you will see this page
    FASI-2 Measure Overview Page
  8. For HCBS-10, you will see this page
    HCBS-10Measure Overview Page

Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

convert to a different template: test → val | val → prod

@rocio-desantiago rocio-desantiago added the ready for review Ready for all the reviews! label Dec 16, 2024
@rocio-desantiago rocio-desantiago self-assigned this Dec 16, 2024
@rocio-desantiago rocio-desantiago changed the title HCBS - QMS - FASI-1, FASI-2, HCBS-10 optional measures [HCBS] QMS - FASI-1, FASI-2, HCBS-10 optional measures Dec 16, 2024
@rocio-desantiago
Copy link
Contributor Author

This is the code climate thing that's complaining:
Codeclimate error encouraging a refactor of qm.ts file

ailZhou
ailZhou previously approved these changes Dec 17, 2024
Copy link
Collaborator

@ailZhou ailZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! tested on deploy and all the pages are showing up and matching the ticket's text

Copy link
Contributor

@benmartin-coforma benmartin-coforma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have one question, but beyond that I approve!

I definitely disagree with CodeClimate on the max length of file; for our purposes it would make way less sense to break that code up.

services/app-api/forms/qm.ts Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Dec 20, 2024

Code Climate has analyzed commit 820dec1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 93.6% (0.0% change).

View more on Code Climate.

@rocio-desantiago rocio-desantiago merged commit 62e3059 into main Dec 20, 2024
19 checks passed
@rocio-desantiago rocio-desantiago deleted the fasi-2 branch December 20, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants