-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HCBS] QMS - FASI-1, FASI-2, HCBS-10 optional measures #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! tested on deploy and all the pages are showing up and matching the ticket's text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have one question, but beyond that I approve!
I definitely disagree with CodeClimate on the max length of file; for our purposes it would make way less sense to break that code up.
820dec1
Code Climate has analyzed commit 820dec1 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 93.6% (0.0% change). View more on Code Climate. |
Description
Related ticket(s)
CMDCT-4155 (FASI-1)
CMDCT-4157 (FASI-2)
CMDCT-4159 (HCBS-10)
How to test
Cloudfront URL: https://d1m8ad8ivtkepf.cloudfront.net/
Author checklist
convert to a different template: test → val | val → prod