Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMDCT-4190: Backend form validation for create banner endpoint #85

Merged
merged 5 commits into from
Jan 6, 2025

Conversation

angelaco11
Copy link
Contributor

@angelaco11 angelaco11 commented Dec 31, 2024

Description

Backend validation for create banner endpoint

Related ticket(s)

CMDCT-4190


How to test

https://d2nqxnjdodub3e.cloudfront.net/
This test is probably just making sure that banner endpoint still works

  1. Log in as adminuser@test.com
  2. create a banner

Copy link

codeclimate bot commented Jan 3, 2025

Code Climate has analyzed commit 01cb1b3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 92.8% (90% is the threshold).

This pull request will bring the total coverage in the repository to 94.0% (0.4% change).

View more on Code Climate.

Copy link
Collaborator

@ailZhou ailZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! tested on deploy and the api layer prevented me from saving an empty description

@angelaco11 angelaco11 merged commit 8a6957f into main Jan 6, 2025
19 checks passed
@angelaco11 angelaco11 deleted the cmdct-4190 branch January 6, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants