Refactored IntegerDivider.java divide method #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the divide method in IntegerDivider.java to use build-in IntToDoubleConverter.Convert instead of the previous duplicated explicit casting, this removes duplicated code and makes the application easier to change. Refactored the if - else if statement into a ternary operator, this reduces state in the application and makes the application less bugprone and more maintainable, note dbRoundedQuotient is now a final variable, instead of a mutable variable. Added a TODO on how to further improve this implementation to make the application even more maintainable, flexible, and extendable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the divide method in IntegerDivider.java to use build-in IntToDoubleConverter.Convert instead of the previous duplicated explicit casting, this removes duplicated code and makes the application easier to change.
Refactored the if - else if statement into a ternary operator, this reduces state in the application and makes the application less bugprone and more maintainable, note dbRoundedQuotient is now a final variable, instead of a mutable variable.
Added a TODO on how to further improve this implementation to make the application even more maintainable, flexible, and extendable.