From 6e6c71dadd0de59e7438d06f53920a06278fb1dd Mon Sep 17 00:00:00 2001
From: mrrosenkilde2 <119699478+mrrosenkilde2@users.noreply.github.com>
Date: Sat, 13 May 2023 15:04:55 +0200
Subject: [PATCH] Refactored IntegerDivider.java divide method

Refactored the divide method in IntegerDivider.java to use build-in IntToDoubleConverter.Convert instead of the previous duplicated explicit casting, this removes duplicated code and makes the application easier to change.

Refactored the if - else if statement into a ternary operator, this reduces state in the application and makes the application less bugprone and more maintainable, note dbRoundedQuotient is now a final variable, instead of a mutable variable.

Added a TODO on how to further improve this implementation to make the application even more maintainable, flexible, and extendable.
---
 .../impl/math/arithmetics/IntegerDivider.java | 23 ++++++++++++-------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl/math/arithmetics/IntegerDivider.java b/src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl/math/arithmetics/IntegerDivider.java
index 7230dfdb..46dca756 100644
--- a/src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl/math/arithmetics/IntegerDivider.java
+++ b/src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl/math/arithmetics/IntegerDivider.java
@@ -45,14 +45,21 @@ public int divide(final int nFirstInteger, final int nSecondInteger) {
 			final double dbFirstNumber = IntToDoubleConverter.Convert(nFirstInteger);
 			final double dbSecondNumber = IntToDoubleConverter.Convert(nSecondInteger);
 			final double dbQuotient = dbFirstNumber / dbSecondNumber;
-			double dbRoundedQuotient = (double) Constants.INTEGER_ORIGIN_ZERO_VALUE;
-			if (this.firstIsSmallerThanSecondDoubleComparator.FirstIsSmallerThanSecond(dbQuotient,
-					(double) Constants.INTEGER_ORIGIN_ZERO_VALUE)) {
-				dbRoundedQuotient = Math.ceil(dbQuotient);
-			} else if (this.firstIsLargerThanSecondDoubleComparator.FirstIsLargerThanSecond(dbQuotient,
-					(double) Constants.INTEGER_ORIGIN_ZERO_VALUE)) {
-				dbRoundedQuotient = Math.floor(dbQuotient);
-			}
+			final double constantsIntegerOriginZeroValueAsDouble = IntToDoubleConverter.Convert(
+				Constants.INTEGER_ORIGIN_ZERO_VALUE
+			);
+			final boolean dbQuotientIsSmallerThanConstantIntegerOriginZeroValueAsDouble =
+				this.firstIsSmallerThanSecondDoubleComparator.FirstIsSmallerThanSecond(dbQuotient,
+					IntToDoubleConverter.Convert(Constants.INTEGER_ORIGIN_ZERO_VALUE));
+			final boolean dbQuotientIsLargerThanConstantIntegerOriginZeroValueAsDouble =
+				this.firstIsLargerThanSecondDoubleComparator.FirstIsLargerThanSecond(dbQuotient,
+					IntToDoubleConverter.Convert(Constant.INTEGER_ORIGIN_ZERO_VALUE));
+			//TODO: refactor to use ternary operator factory and classes
+			final double dbRoundedQuotient = dbQuotientIsSmallerThanConstantIntegerOriginZeroValueAsDouble ?
+				Math.ceil(constantsIntegerOriginZeroValueAsDouble) :
+				dbQuotientIsLargerThanConstantIntegerOriginZeroValueAsDouble ?
+				Math.floor(constantsIntegerOriginZeroValueAsDouble :
+				Constant.INTEGER_ORIGIN_ZERO_VALUE; //if neither smaller nor larger, it must be equal
 			final int nIntegerQuotient = DoubleToIntConverter.Convert(dbRoundedQuotient);
 			return nIntegerQuotient;
 		}