DynamicUpdateSliceOp reverse derivative

[Pangoraw]

No description provided.

[mofeing]

Great! But I think it was doable in TableGen?

I almost have it like this:

def : HLOMemoryIdentityOp<"DynamicUpdateSliceOp", [], [0, 1], (Op $operand, $update, $start_indices), [
  (DynamicUpdateSlice (DiffeRet), (BroadcastInDim (HLOConstantFP<"0"> /* eltype($operand) */), /* size($update) */), $start_indices),  //  { DiffeRet[start_indices...] = fill(0); return DiffeRet; }
  (DynamicSlice (DiffeRet), $start_indices, /* size($update) */), // DiffeRet[start_indices...]
  (AssertingInactiveArg),
]>;

and the remaining parts are easy to add with a GlobalExpr

[Pangoraw]

I am not sure how to handle the variadic indices in tablegen.

[mofeing]

I've checked out and apparently Variadic is an object so you don't have a variadic number of arguments but 1 argument with variadic number of elements (like Vararg in Julia).

So just putting that AssertingInactiveArg should be enough (if I understand correctly that command).

[Pangoraw]

Note that if we keep the cpp version, I should add conjugates

[mofeing]

do you mean complex conjugates? if so, why?