Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Treashunt 2028 S2 Project background image #141

Merged
merged 7 commits into from
Sep 16, 2024

Conversation

feove
Copy link
Contributor

@feove feove commented Sep 11, 2024

Sorry I didn't reduce the size of the old background gif in my old commit; I thought the limit was less than 5 Mb.

@matiboux matiboux self-assigned this Sep 11, 2024
@matiboux
Copy link
Member

This PR supersedes #140.

@matiboux
Copy link
Member

I'm sorry, your S2 project must be displayed in a medium-sized tile, as all other S2 projects are.

I've made change to resize the tile and update CSS properties to adapt the background size and position.
See my changes in commit b8ecaae.

Please review my commit and choose whether to give the go-ahead for merging!

@matiboux matiboux changed the title Change size of old background gif Change Treashunt 2028 S2 Project background image Sep 11, 2024
Copy link
Member

@matiboux matiboux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest merge commit introduced an issue in the item's CSS properties, see suggested change.

app/src/data/2028.yml Outdated Show resolved Hide resolved
Co-authored-by: Mati <matiboux@gmail.com>
Copy link
Member

@matiboux matiboux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues resolved, thank you for the contribution!

@matiboux matiboux merged commit 0fb1d3d into Epidocs:master Sep 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants