Cleanup docker containers on termination #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--rm` switch tells docker to cleanup containers on termination. Without this an exlicit `remove` is required after `stop` to clean up the container and a `prune` to remove arbitarary volumes left behind. While these are not difficult actions to perform, we are often unaware that we need to do them. I've also changed `kill` to `stop` because `stop` in the drop fn because `stop` attempts to shutdown the container gracefully.
jbearer
approved these changes
Feb 28, 2024
|
Since contrainers are now removed on termination why not also remove the explicit |
Because docker is now doing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--rmswitch tells docker to cleanup containers on termination. Without this an explicitremoveis required afterstopto clean up the container and apruneto remove arbitrary volumes left behind. While these are not difficult actions to perform, we are often unaware that we need to do them.I've also changed
killtostopbecausestopin the drop fn becausestopattempts to shutdown the container gracefully.