[Update] Improve Sample Viewer search #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yo1995
reviewed
Aug 2, 2023
Co-authored-by: Ting <tchen@esri.com>
yo1995
reviewed
Aug 2, 2023
Co-authored-by: Ting <tchen@esri.com>
yo1995
reviewed
Aug 3, 2023
yo1995
reviewed
Aug 4, 2023
[Fix] Remove the relevant APIs from the tags in the `Sample` struct
philium
reviewed
Aug 7, 2023
|
I'll assign this PR to myself and work on the feedback. |
philium
reviewed
Aug 9, 2023
Co-authored-by: Philip Ridgeway <pridgeway@esri.com>
Use `symbolVariant` instead of ternary operator. Co-authored-by: Philip Ridgeway <pridgeway@esri.com>
Only make the tags a set at the last step of code generation, so it keeps the order for the most part. Co-authored-by: Philip Ridgeway <pridgeway@esri.com>
yo1995
reviewed
Aug 10, 2023
philium
reviewed
Aug 10, 2023
To allow the compiler to synthesize the default initializer.
philium
approved these changes
Aug 11, 2023
dfeinzimer
approved these changes
Aug 14, 2023
|
Thanks for all your suggestions! |
|
When I was closing the opened tabs, I found the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the sample search bar in the Sample Viewer to include the searching of a sample's description and tags in addition to the name. Currently, the search bar performs a partial-text search on the names, a partial-text search on the descriptions, and a full-text search on the tags, in that order. The search results are divided into three sections, Name, Description, and Tags. Sections do not include samples that were found in a previous section, if any. Also, sections that have no results are hidden. If the search query is empty, a list of all the samples is displayed, sorted by name. Additionally, the query search text is bolded in the sample names and descriptions.
Linked Issue(s)
swift/issues/4230How To Test
Screenshots
To Discuss
A couple things to think about:
AttributedString)