Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Display alternate symbols at different scales #522

Merged
merged 8 commits into from
Oct 17, 2024

Conversation

CalebRas
Copy link
Collaborator

@CalebRas CalebRas commented Oct 15, 2024

Description

This PR implements Display alternate symbols at different scales in SAMPLE_CATEGORY category.
URL to README: Display alternate symbols at different scales

Linked Issue(s)

  • swift/issues/6187

How To Test

  • Zoom in and out to see the alternate symbols at different scales.

Screenshots

display-alternate-symbols-at-different-scales

@CalebRas CalebRas self-assigned this Oct 15, 2024
@CalebRas CalebRas requested review from a team, pgruenler and njarecha and removed request for a team October 16, 2024 16:32
Copy link
Contributor

@pgruenler pgruenler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One documentation comment looks incomplete.

pgruenler
pgruenler previously approved these changes Oct 16, 2024
njarecha
njarecha previously approved these changes Oct 17, 2024
Copy link
Contributor

@njarecha njarecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@CalebRas CalebRas dismissed stale reviews from njarecha and pgruenler via 7cf0923 October 17, 2024 16:13
@CalebRas
Copy link
Collaborator Author

Sorry I had to merged with v.next.

@CalebRas
Copy link
Collaborator Author

Thank you!

@CalebRas CalebRas merged commit e1cf55f into v.next Oct 17, 2024
1 check passed
@CalebRas CalebRas deleted the Caleb/New-DisplayAlternateSymbolsAtDifferentScales branch October 17, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants