Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] List contents of KML file #526

Merged
merged 10 commits into from
Oct 23, 2024
Merged

Conversation

CalebRas
Copy link
Collaborator

Description

This PR implements List contents of KML file in Edit and Manage Data category.
URL to README: List contents of KML file

Linked Issue(s)

  • swift/issues/6193

How To Test

  • Tap on a disclosure to reveal a node's children. Tap on a node to open it in a scene zoomed to that node.

Screenshots

list-contents-of-kml-file

@CalebRas CalebRas self-assigned this Oct 19, 2024
@CalebRas CalebRas requested review from a team, mhdostal, zkline101 and des12437 and removed request for a team and mhdostal October 19, 2024 00:48
@CalebRas
Copy link
Collaborator Author

Removed Mark since he is out Monday.

des12437
des12437 previously approved these changes Oct 21, 2024
Copy link
Contributor

@des12437 des12437 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment.

des12437
des12437 previously approved these changes Oct 21, 2024
des12437
des12437 previously approved these changes Oct 22, 2024
@CalebRas
Copy link
Collaborator Author

@zkline101 Could you take look at this before Destiny leaves on vacation please? Thank you

@zkline101
Copy link
Contributor

Whoops missed this. I'll review now.

@CalebRas
Copy link
Collaborator Author

Thank you both!

@CalebRas CalebRas merged commit 285a023 into v.next Oct 23, 2024
1 check passed
@CalebRas CalebRas deleted the Caleb/New-ListContentsOfKMLFile branch October 23, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants