Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

date-picker, input-date-picker : refactor selectors in e2e tests #10588

Closed
1 of 5 tasks
anveshmekala opened this issue Oct 23, 2024 · 1 comment
Closed
1 of 5 tasks

date-picker, input-date-picker : refactor selectors in e2e tests #10588

anveshmekala opened this issue Oct 23, 2024 · 1 comment
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked. spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. testing Issues related to automated or manual testing.

Comments

@anveshmekala
Copy link
Contributor

anveshmekala commented Oct 23, 2024 •
edited
Loading

Description

Currently we are leveraging nested piercing selector in date-picker & input-date-picker tests which can be hard to maintain.
This issue serves as spike story to identify if this can be avoided and improve selectors we use in e2e tests.

Proposed Advantages

Improves readability and maintainability
More robust

Which Component

  • date-picker
  • input-date-picker

Relevant Info

Stems from #8402 (comment)

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@anveshmekala anveshmekala added refactor Issues tied to code that needs to be significantly reworked. testing Issues related to automated or manual testing. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. labels Oct 23, 2024
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Oct 23, 2024
@anveshmekala
Copy link
Contributor Author

closed since this is already covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked. spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. testing Issues related to automated or manual testing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anveshmekala