Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Time Picker] Displays incorrect initial value when hour-format="24" #11198

Closed
4 of 8 tasks
geospatialem opened this issue Jan 3, 2025 · 2 comments
Closed
4 of 8 tasks

[Time Picker] Displays incorrect initial value when hour-format="24" #11198

geospatialem opened this issue Jan 3, 2025 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2025-01-30 - 3.0....

Comments

@geospatialem
Copy link
Member

geospatialem commented Jan 3, 2025 •
edited
Loading

Check existing issues

Actual Behavior

When the hour value of the component is over 12, on initialization the 12-hour number is present until the minute is specified.
verify-4756

Additionally, users are unable to see numbers between 13-24 until after the component's minutes are specified.

verify-4756-2

@eriklharper identified its unrelated to the hourFormat PR effort, as it occurs using the time-picker as a standalone, so its the source of the bug.

Expected Behavior

  • The 24-hour number is present on initialization if a user enters it in the component
  • Users can see a list of hour numbers from 0-24 on initialization when interacting with the component

Reproduction Sample

https://codepen.io/geospatialem/pen/RNbjWoM

Reproduction Steps

  1. Open the sample
  2. Open the component
  3. Enter a number over 12 (e.g., 13) for the hour
  4. Observe the hour represents the 12 hour number
  5. Select a number for the minute
  6. Observe the component will change to the 24-hour number

Reproduction Version

3.0.0-next.87

Relevant Info

Surfaced while verifying #4756, more info in this comment: #4756 (comment)

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

High with the introduction of the hour-format="24", where it appears the functionality is broken on initialization.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)
@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - high Issue should be addressed in the current milestone, impacts component or core functionality 1 - assigned Issues that are assigned to a sprint and a team member. estimate - 3 A day or two of work, likely requires updates to tests. labels Jan 3, 2025
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Jan 3, 2025
@geospatialem geospatialem mentioned this issue Jan 3, 2025
Closed
@eriklharper eriklharper mentioned this issue Jan 3, 2025
Merged
@eriklharper eriklharper added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jan 3, 2025
eriklharper added a commit that referenced this issue Jan 4, 2025
@eriklharper
fix(time-picker): display correct localized hour based on hour-format…
a938192 
… when no value is set (#11200)

**Related Issue:** #11198 

## Summary

This PR fixes an issue where if no valid time value is currently set,
the `time-picker` component doesn't display the hour in the
corresponding `hour-format`.

BEGIN_COMMIT_OVERRIDE
omitted from changelog
END_COMMIT_OVERRIDE
@eriklharper eriklharper added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jan 4, 2025
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned eriklharper Jan 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2025

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 6, 2025
@geospatialem
Copy link
Member Author

Verified on the dev branch 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2025-01-30 - 3.0.0 Jan Breaking Chang...
Development

No branches or pull requests
3 participants
@eriklharper @geospatialem @DitwanP