Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[combobox, list] filter should apply to groups #7702

Closed
2 of 3 tasks
jcfranco opened this issue Sep 8, 2023 · 5 comments
Closed
2 of 3 tasks

[combobox, list] filter should apply to groups #7702

jcfranco opened this issue Sep 8, 2023 · 5 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-combobox Issues that pertain to the calcite-combobox and related components c-list Issues that pertain to the calcite-list component Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library p4 - not time sensitive User set priority status of p4 - not time sensitive ready for dev Issues ready for development implementation.
Milestone
2025-01-30 - 3.0....

Comments

@jcfranco
Copy link
Member

jcfranco commented Sep 8, 2023 •
edited
Loading

Check existing issues

Actual Behavior

The current filtering only applies to items, but should also include groups and any matches should show all items under a matching group.

Expected Behavior

Filter applies to both items and groups.

Reproduction Sample

https://codepen.io/jcfranco/pen/yLGgmWv?editors=100

Reproduction Steps

  1. Focus on a component's filter/input
  2. Type the search text displayed in any use case's placeholder text
  3. Group and child items are not displayed.

Reproduction Version

1.8.0

Relevant Info

No response

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

Calcite (dev)
@jcfranco jcfranco added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. c-combobox Issues that pertain to the calcite-combobox and related components labels Sep 8, 2023
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive Calcite (dev) Issues logged by Calcite developers. labels Sep 8, 2023
@jcfranco jcfranco added the c-list Issues that pertain to the calcite-list component label Sep 8, 2023
@jcfranco jcfranco changed the title combobox filter should apply to groups [combobox, list, pick-list] filter should apply to groups Sep 8, 2023
@geospatialem geospatialem added design Issues that need design consultation prior to development. estimate - 3 A day or two of work, likely requires updates to tests. labels Sep 18, 2023
@geospatialem
Copy link
Member

Priority and expertise sought from the design team.

@ashetland
Copy link
Contributor

No hesitation from design. 🚀

@ashetland ashetland added p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation. and removed needs triage Planning workflow - pending design/dev review. labels Oct 2, 2023
@github-actions github-actions bot added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

cc @geospatialem, @brittneytewks

@geospatialem geospatialem added this to the 2024 April Priorities milestone Nov 22, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Nov 22, 2023
@brittneytewks brittneytewks added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Mar 25, 2024
@brittneytewks brittneytewks removed this from the 2024-04-30 - Apr Release milestone Mar 25, 2024
@geospatialem geospatialem added this to the 2024-07-30 - Jul Release milestone Apr 3, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 3, 2024
@geospatialem geospatialem changed the title [combobox, list, pick-list] filter should apply to groups [combobox, list] filter should apply to groups Aug 29, 2024
@github-actions github-actions bot added the p4 - not time sensitive User set priority status of p4 - not time sensitive label Aug 29, 2024
@anveshmekala anveshmekala self-assigned this Oct 9, 2024
@anveshmekala anveshmekala mentioned this issue Oct 9, 2024
Merged
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Oct 14, 2024
@anveshmekala anveshmekala mentioned this issue Oct 31, 2024
Merged
anveshmekala added a commit that referenced this issue Oct 31, 2024
@anveshmekala
fix(combobox): include groups in filtering (#10511)
e706178 
**Related Issue:** #7702 

## Summary

Includes groups while filtering in `calcite-combobox`.
@driskull driskull mentioned this issue Dec 30, 2024
Open
6 tasks
anveshmekala added a commit that referenced this issue Jan 2, 2025
@anveshmekala
fix(list): include groups in filtering (#10664)
904623b 
**Related Issue:** #7702 

## Summary

- Include `calcite-list-item-group` in filtering.
- group's `heading` can be used as `filterProp`.
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jan 2, 2025
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned anveshmekala Jan 2, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 3, 2025
@geospatialem
Copy link
Member

Verified in 3.0.0-next.88 with combobox and list groups specified in combobox-item-group's label and list-item-group's heading. 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-combobox Issues that pertain to the calcite-combobox and related components c-list Issues that pertain to the calcite-list component Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library p4 - not time sensitive User set priority status of p4 - not time sensitive ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2025-01-30 - 3.0.0 Jan Breaking Chang...
Development

No branches or pull requests
6 participants
@jcfranco @geospatialem @DitwanP @anveshmekala @ashetland @brittneytewks