feat(pagination): add component tokens #11157
Open
+153
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
alisonailea
requested changes
Dec 30, 2024
| * These properties can be overridden using the component's tag as selector. | ||
| * | ||
| * @prop --calcite-pagination-spacing: Specifies the amount of left and right margin spacing between each item. | ||
| * @prop --calcite-pagination-width: Specifies the width of each item. |
There was a problem hiding this comment.
This should be pagination-size
| * @prop --calcite-pagination-width: Specifies the width of each item. | ||
| * @prop --calcite-pagination-color: Specifies the component's item color. | ||
| * @prop --calcite-pagination-selected-color-hover: Specifies the component's item color when hovered or selected. | ||
| * @prop --calcite-pagination-hover-bottom-border-color: Specifies the component's item bottom border color when hovered. |
There was a problem hiding this comment.
This should be --calcite-pagination-color-border-hover
| * @prop --calcite-pagination-color: Specifies the component's item color. | ||
| * @prop --calcite-pagination-selected-color-hover: Specifies the component's item color when hovered or selected. | ||
| * @prop --calcite-pagination-hover-bottom-border-color: Specifies the component's item bottom border color when hovered. | ||
| * @prop --calcite-pagination-selected-bottom-border-color: Specifies the component's item bottom border color when selected. |
There was a problem hiding this comment.
this should be --calcite-pagination-color-border-active
| * @prop --calcite-pagination-selected-color-hover: Specifies the component's item color when hovered or selected. | ||
| * @prop --calcite-pagination-hover-bottom-border-color: Specifies the component's item bottom border color when hovered. | ||
| * @prop --calcite-pagination-selected-bottom-border-color: Specifies the component's item bottom border color when selected. | ||
| * @prop --calcite-pagination-active-background-color: Specifies the component's item background color when active. |
There was a problem hiding this comment.
--calcite-pagination-color-background-color
| * @prop --calcite-pagination-hover-bottom-border-color: Specifies the component's item bottom border color when hovered. | ||
| * @prop --calcite-pagination-selected-bottom-border-color: Specifies the component's item bottom border color when selected. | ||
| * @prop --calcite-pagination-active-background-color: Specifies the component's item background color when active. | ||
| * @prop --calcite-pagination-hover-chevron-background-color: Specifies the component's chevron item background color when hovered. |
There was a problem hiding this comment.
--calcite-pagination-chevron-color-background-hover
| * @prop --calcite-pagination-spacing: Specifies the amount of left and right margin spacing between each item. | ||
| * @prop --calcite-pagination-width: Specifies the width of each item. | ||
| * @prop --calcite-pagination-color: Specifies the component's item color. | ||
| * @prop --calcite-pagination-selected-color-hover: Specifies the component's item color when hovered or selected. |
There was a problem hiding this comment.
This can be simplified down to --calcite-pagination-color-hover
| @@ -21,7 +36,7 @@ | |||
| & .page, | |||
| & .ellipsis { | |||
| @apply text-n2h h-6 px-1; | |||
| min-inline-size: theme("width.6"); | |||
| --width: theme("width.6"); | |||
There was a problem hiding this comment.
you should not assign tokens inside components unless they are -internal
| @@ -30,7 +45,7 @@ | |||
| & .page, | |||
| & .ellipsis { | |||
| @apply text-n1h h-8 px-2; | |||
| min-inline-size: theme("width.8"); | |||
| --width: theme("width.8"); | |||
There was a problem hiding this comment.
you should not assign tokens inside components unless they are -internal
| @@ -39,7 +54,7 @@ | |||
| & .page, | |||
| & .ellipsis { | |||
| @apply text-0h h-11; | |||
| min-inline-size: theme("width.11"); | |||
| --width: theme("width.11"); | |||
There was a problem hiding this comment.
you should not assign tokens inside components unless they are -internal
…ciado88/7180-add-pagination-design-tokens
…ciado88/7180-add-pagination-design-tokens
|
@alisonailea I'm having issues with some token e2e tests, could you please take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Add
paginationcomponent tokens.--calcite-pagination-spacing: Specifies the amount of left and right margin spacing between each item.--calcite-pagination-size: Specifies the width of each item.--calcite-pagination-color: Specifies the component's item color.--calcite-pagination-color-hover: Specifies the component's item color when hovered or selected.--calcite-pagination-color-border-hover: Specifies the component's item bottom border color when hovered.--calcite-pagination-color-border-active: Specifies the component's item bottom border color when selected.--calcite-pagination-color-background: Specifies the component's item background color when active.--calcite-pagination-chevron-color-background-hover: Specifies the component's chevron item background color when hovered.