fix(tile-group): keep selection icon size consistent for large tiles #11215
Conversation
github-actions
bot
added
the
bug
jcfranco
added
the
pr ready for visual snapshots
| </div> | ||
| `; | ||
| export const allVariantsHorizontal = createVariantsHtmlStory("horizontal"); | ||
| export const allVariantsVertical = createVariantsHtmlStory("vertical"); |
There was a problem hiding this comment.
I think you broke Chromatic 😄 https://www.chromatic.com/test?appId=6266d45509d7eb004aa254fb&id=677ce7bbb76f8e6437051490
There was a problem hiding this comment.
Oh noes! @eriklharper Would a shorter description value help here? We could split the all-variants stories, but it sort of defeats the purpose. 🥲
There was a problem hiding this comment.
You'd have to just try shortening it I suppose and see it makes it small enough for Chromatic to capture, but yeah, possibly that could make a difference.
|
I'm seeing a hover border regression where the right side of the middle hovered tile doesn't appear correctly. Could be a stacking issue:
|
jcfranco
added
pr ready for visual snapshots
|
@eriklharper Fixed the hover outline regression. Would you mind taking another look? |
Related Issue: #10931
Summary
Fixes an issue where large tiles (w/o
description) would cause the selection icon to be oversized and misaligned.Noteworthy changes