Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): add docs package export #11221

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Jan 7, 2025

Related Issue: #10731

Summary

Adds package export to support doc-related ESM imports.

BEGIN_COMMIT_OVERRIDE
omitted from changelog
END_COMMIT_OVERRIDE

@jcfranco jcfranco requested a review from benelan as a code owner January 7, 2025 20:47
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jan 7, 2025
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Jan 7, 2025
Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
I will add this to starter package: https://devtopia.esri.com/WebGIS/arcgis-web-components/issues/2949

@jcfranco jcfranco added the no changelog entry Use the commit override to avoid a changelog entry label Jan 7, 2025
@jcfranco jcfranco merged commit 4b0d804 into dev Jan 7, 2025
20 of 21 checks passed
@jcfranco jcfranco deleted the jcfranco/10731-add-docs-package-export branch January 7, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. no changelog entry Use the commit override to avoid a changelog entry skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants