fix(combobox): fix accessibility when an item's heading or label changes #11289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
|
It looks like the a11y test still fails. 😞 I've skipped it for the time being. The changes seem helpful though. Can you create an issue to make sure they go through the verification process? |
|
@jcfranco this one is failing as well: |
driskull
added
the
skip visual snapshots
|
@jcfranco created issue and added test. Can I get a review? |
jcfranco
reviewed
Jan 14, 2025
packages/calcite-components/src/components/combobox-item/combobox-item.e2e.ts
Outdated
Show resolved
Hide resolved
github-actions
bot
added this to the 2025-01-30 - 3.0.0 Jan Breaking Change Release milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #11301
Summary
headingorlabelchangeslabelas an ariaLabel on the accessible element.