-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(filter): add component tokens #8598
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… element spacing for better visual hierarchy. #7100
# Conflicts: # packages/calcite-components/src/components/list-item/list-item.scss # packages/calcite-components/src/components/list-item/resources.ts
# Conflicts: # packages/calcite-components/src/components/list-item/list-item.tsx
# Conflicts: # packages/calcite-components/src/components.d.ts
driskull
added
the
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
label
Jan 12, 2024
github-actions
bot
added
the
enhancement
Issues tied to a new feature or request.
label
Jan 12, 2024
driskull
added
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
and removed
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
labels
Jan 12, 2024
driskull
added
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
and removed
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
labels
Jan 12, 2024
driskull
added
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
and removed
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
labels
Jan 13, 2024
driskull
added a commit
that referenced
this pull request
Jan 13, 2024
driskull
added a commit
that referenced
this pull request
Jan 13, 2024
driskull
removed
the
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
label
Jan 16, 2024
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
Issues or pull requests that have not had recent activity.
label
Jan 24, 2024
alisonailea
requested changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be broken into separate PRs?
hey @alisonailea these are draft PRs not ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Issues tied to a new feature or request.
Stale
Issues or pull requests that have not had recent activity.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
calcite-filter
Adds the following component tokens:
--calcite-filter-background-color
--calcite-filter-width