Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filter): add component tokens #8598

Closed
wants to merge 20 commits into from

Conversation

driskull
Copy link
Member

@driskull driskull commented Jan 12, 2024

Related Issue: #7180

Summary

  • Add component tokens for calcite-filter
  • Remove CSS that isn't doing anything
  • Add story

Adds the following component tokens:

  • --calcite-filter-background-color
  • --calcite-filter-width

@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 12, 2024
@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Jan 12, 2024
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jan 12, 2024
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jan 12, 2024
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jan 13, 2024
driskull added a commit that referenced this pull request Jan 13, 2024
driskull added a commit that referenced this pull request Jan 13, 2024
@driskull driskull removed the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 16, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jan 24, 2024
Copy link
Contributor

@alisonailea alisonailea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be broken into separate PRs?

@driskull
Copy link
Member Author

driskull commented Feb 9, 2024

hey @alisonailea these are draft PRs not ready for review.

@driskull driskull changed the base branch from main to epic/7180-component-tokens February 9, 2024 22:58
@driskull driskull closed this Feb 9, 2024
@driskull driskull deleted the dris0000/filter-tokens branch February 9, 2024 23:01
driskull added a commit that referenced this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants