Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scrim): Add component tokens #8662

Merged

Conversation

macandcheese
Copy link
Contributor

Related Issue: #7180

Summary

--calcite-scrim-background-color: Specifies the background color of the component.

Adds a deprecated tag and fallback for the previous --calcite-scrim-background css property.

@macandcheese macandcheese requested a review from a team as a code owner January 29, 2024 18:22
Copy link
Contributor

@eriklharper eriklharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. This question applies to any of these new component token changes, but I'm wondering if we should add a storybook story that overrides all of the publicly documented tokens for visual regression tracking?

@macandcheese macandcheese added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 29, 2024
Copy link
Contributor

github-actions bot commented Feb 7, 2024

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Feb 7, 2024
@macandcheese macandcheese removed the Stale Issues or pull requests that have not had recent activity. label Feb 7, 2024
@macandcheese macandcheese merged commit 21fee6e into epic/7180-component-tokens Feb 12, 2024
4 checks passed
@macandcheese macandcheese deleted the macandcheese/token-update-scrim branch February 12, 2024 23:03
Elijbet pushed a commit that referenced this pull request Feb 15, 2024
**Related Issue:** #7180 

## Summary
`--calcite-scrim-background-color`: Specifies the background color of
the component.

Adds a deprecated tag and fallback for the previous
`--calcite-scrim-background` css property.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants