-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(color-picker): add component token E2E tests #9737
test(color-picker): add component token E2E tests #9737
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened the tests in debugger mode and it looks like several of the tokens are not applied?
packages/calcite-components/src/components/color-picker/color-picker.e2e.ts
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/color-picker/color-picker.e2e.ts
Show resolved
Hide resolved
packages/calcite-components/src/components/color-picker/color-picker.e2e.ts
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/color-picker/color-picker.e2e.ts
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/color-picker/color-picker.e2e.ts
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/color-picker/color-picker.e2e.ts
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/color-picker/color-picker.e2e.ts
Outdated
Show resolved
Hide resolved
@alisonailea I've removed some of the unused props you pointed out. Thanks for the catch! ✨🎣✨ Others that were pointed out were working, but not shown up for specific configurations or because there was an issue with styles. I've also fixed these and here's how they're looking: A couple of questions on ☝️:
|
|
@alisonailea Updated. Would you mind reviewing this again? 🙏 |
Related Issue: #7180
Summary
✨🧪✨