Fix trade signs not updating with full inventories #5574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with 1.19, sign block states are no longer persistent causing them to become dead after any call to Sign#update. To avoid this, ensure we either always get the latest block state or update the block state after any call to Sign#update.
JRoy
added
type: bugfix
pop4959
approved these changes
Nov 11, 2023
auto-merge was automatically disabled
November 11, 2023 02:19
Pull request was closed
HarvelsX
pushed a commit
to HarvelsX/Essentials
that referenced
this pull request
Jun 2, 2024
Starting with 1.19, sign block states are no longer persistent causing them to become dead after any call to Sign#update. To avoid this, ensure we either always get the latest block state or update the block state after any call to Sign#update.
Starmism
pushed a commit
to valence-smp/Essentials
that referenced
this pull request
Jan 8, 2025
Starting with 1.19, sign block states are no longer persistent causing them to become dead after any call to Sign#update. To avoid this, ensure we either always get the latest block state or update the block state after any call to Sign#update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with 1.19, sign block states are no longer persistent causing them to become dead after any call to Sign#update. To avoid this, ensure we either
always get the latest block state or update the block state after any call to Sign#update.
Fixes #5550