Remove extraneous code in command preprocess event handling #5981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no need to recreate a HashMap instance to prevent concurrency since user.getCommandCooldowns() already makes a new HashMap instance the second if condition verifying entry.getValue() > System.currentTimeMillis() is redundant as it is already implied by the first if condition Don't break in case there are other command cooldowns left to clear
JRoy
previously approved these changes
Nov 30, 2024
|
Good catch, thanks! |
JRoy
changed the title
JRoy
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no need to recreate a HashMap instance to prevent concurrency since user.getCommandCooldowns() already makes a new HashMap instance
the second if condition verifying entry.getValue() > System.currentTimeMillis() is redundant as it is already implied by the first if condition
Don't break in case there are other command cooldowns left to clear
You need to select a pull request template!
If you're adding a new feature, copy and paste the following parameter at the end of the URL:
?template=new-feature.md
If you're fixing a bug, copy and paste the following parameter at the end of the URL:
?template=bug-fix.md
For more information about contributing to EssentialsX, see CONTRIBUTING.md:
https://github.com/EssentialsX/Essentials/blob/2.x/CONTRIBUTING.md