Fix RoomSpawnpoint

[SrLicht]

Description

Describe the changes
Fixes RoomSpawnPoint when used in Surface and also changing the spawn eventarg to WaitingForPlayers.

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:
Proof what the change is working and dont brake the position

PillsSpawnPoints its a List of RoomSpawnPoints where some are in Surface

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentations

Submission checklist

• I have checked the project can be compiled
• I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

• I have checked no IL patching errors in the console

Other

• Still requires more testing

[SrLicht]

I fixed uwu @Josephfallen

[Josephfallen]

Thank you @SrLicht I'll look over it once I finish my code :)

[SrLicht]

Thank you n-n

I've already tested the changes and they work before my items appeared in Y 2000 and now they appear correctly in Surface

[Josephfallen]

@SrLicht If you want it reviewed you have to make it public

[Josephfallen]

If tested, It looks good

[VALERA771]

If tested

[SrLicht]

I was too lazy to type the commit from my damn cell phone so I used a translator.

[louis1706]

This would be good if exiled OnWaitingPlayer get call when locker have finish to spawn too

[SrLicht]

And how do you know when the lockers are created?

The Exiled lockers are created in the Awake of the base game lockers but the only way to know if they are already created would be to increase the delay that OnWaitingForPlayers already has.

[louis1706]

Fuck that kinda problematic yeah

[louis1706]

Write bug report for locker not being prepared when OnWaitingPlayer is call

[SrLicht]

Write bug report for locker not being prepared when OnWaitingPlayer is call

In Github or Discord ?

[iamalexrouse]

Write bug report for locker not being prepared when OnWaitingPlayer is call

In Github or Discord ?

In GitHub is usually better, but it's more preference and GitHub allows for issues to be linked with pull requests.

[louis1706]

Write bug report for locker not being prepared when OnWaitingPlayer is call

In Github or Discord ?

Discord & Github (or only github)

[SrLicht]

@louis1706
What do you think about this ?

Spawn the customitems in RoundStarted but move the spawn handler to a coroutine with a delay of a couple of frames to avoid lag when spawning too many items.

/// <summary>
/// Spawns <see cref="CustomItem"/>s inside <paramref name="spawnPoints"/>.
/// </summary>
/// <param name="spawnPoints">The spawn points <see cref="IEnumerable{T}"/>.</param>
/// <param name="limit">The spawn limit.</param>
/// <returns>Returns the number of spawned items.</returns>
public virtual uint Spawn(IEnumerable<SpawnPoint> spawnPoints, uint limit)
{
    uint spawned = 0;

    foreach (SpawnPoint spawnPoint in spawnPoints)
    {
        Log.Debug($"Attempting to spawn {Name} at {spawnPoint.Position}.");

        // Check if the spawn chance or the limit prevents spawning.
        if (Loader.Random.NextDouble() * 100 >= spawnPoint.Chance || (limit > 0 && spawned >= limit))
            continue;

        spawned++;

        // Call the private method to handle the item spawn with delay.
        Timing.RunCoroutine(SpawnItemWithDelay(spawnPoint));
    }

    return spawned;
}

        /// <summary>
        /// Handles the spawning logic for a single item at a given spawn point,
        /// including any necessary delays to prevent spawning too many items at once.
        /// </summary>
        /// <param name="spawnPoint">The spawn point where the item should be spawned.</param>
        /// <returns>Yields control back to allow other items to spawn with a delay.</returns>
        protected virtual IEnumerator<float> SpawnItemWithDelay(SpawnPoint spawnPoint)
        {
            // Special handling for dynamic spawn points, such as spawning inside lockers.
#pragma warning disable CS0618 // Type or member is obsolete
            if (spawnPoint is DynamicSpawnPoint dynamicSpawnPoint && dynamicSpawnPoint.Location == SpawnLocationType.InsideLocker)
            {
                for (int i = 0; i < 50; i++)
                {
                    if (Map.Lockers is null)
                    {
                        Log.Debug($"{nameof(Spawn)}: Locker list is null.");
                        continue;
                    }

                    Locker locker = Map.Lockers[Loader.Random.Next(Map.Lockers.Count)];

                    if (locker is null)
                    {
                        Log.Debug($"{nameof(Spawn)}: Selected locker is null.");
                        continue;
                    }

                    if (locker.Loot is null)
                    {
                        Log.Debug($"{nameof(Spawn)}: Invalid locker location. Attempting to find a new one..");
                        continue;
                    }

                    if (locker.Chambers is null)
                    {
                        Log.Debug($"{nameof(Spawn)}: Locker chambers are null");
                        continue;
                    }

                    LockerChamber chamber = locker.Chambers[Loader.Random.Next(Mathf.Max(0, locker.Chambers.Length - 1))];

                    if (chamber is null)
                    {
                        Log.Debug($"{nameof(Spawn)}: Chamber is null");
                        continue;
                    }

                    Vector3 position = chamber._spawnpoint.transform.position;
                    Pickup? pickup = Spawn(position, null);

                    // Update firearm status if applicable.
                    if (pickup?.Base is BaseFirearmPickup firearmPickup && this is CustomWeapon customWeapon)
                    {
                        firearmPickup.Status = new FirearmStatus(customWeapon.ClipSize, firearmPickup.Status.Flags, firearmPickup.Status.Attachments);
                        firearmPickup.NetworkStatus = firearmPickup.Status;
                    }

                    Log.Debug($"Spawned {Name} at {position} ({spawnPoint.Name})");

                    // Delay before attempting the next spawn.
                    yield return Timing.WaitForSeconds(0.1f);
                    break;
                }
            }
            else
            {
                Pickup? pickup = Spawn(spawnPoint.Position, null);

                // Update firearm status if applicable.
                if (pickup?.Base is BaseFirearmPickup firearmPickup && this is CustomWeapon customWeapon)
                {
                    firearmPickup.Status = new FirearmStatus(customWeapon.ClipSize, firearmPickup.Status.Flags, firearmPickup.Status.Attachments);
                    firearmPickup.NetworkStatus = firearmPickup.Status;
                }

                Log.Debug($"Spawned {Name} at {spawnPoint.Position} ({spawnPoint.Name})");

                // Delay before attempting the next spawn.
                yield return Timing.WaitForSeconds(0.1f);
            }
#pragma warning restore CS0618 // Type or member is obsolete
        }
        

Testings

I was testing a few rounds and spawned around 50 pickups at the start of the round and did not notice any micro-lags from using the method.