fix: [EXILED::Events] Fixed the ChangingRoleAndSpawned.ChangeInventory NullReferenceException skill issue
#172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggestion ExMod-Team#1 Co-authored-by: Alex Rouse <123724383+ALEXWARELLC@users.noreply.github.com>
Co-authored-by: Alex Rouse <123724383+ALEXWARELLC@users.noreply.github.com>
private methods should be defined after public ones
Co-authored-by: Alex Rouse <123724383+ALEXWARELLC@users.noreply.github.com>
Co-authored-by: Alex Rouse <123724383+ALEXWARELLC@users.noreply.github.com>
Co-authored-by: Alex Rouse <123724383+ALEXWARELLC@users.noreply.github.com>
|
This do not fix the issue than the event argument is null |
louis1706
added
Do not merge
|
not an EXILED bug if the function receive a null argument ig |
it's not null argument inside the event it's null event so yes it's exiled bug |
if (ev == null) should be always useless |
louis1706
approved these changes
Nov 18, 2024
louis1706
changed the title
[EXILED::Events] Fixed the ChangingRoleAndSpawned.ChangeInventory NullReferenceException skill issue[EXILED::Events] Fixed the ChangingRoleAndSpawned.ChangeInventory NullReferenceException skill issue
VALERA771
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the
System.NullReferenceException: Object reference not set to an instance of an objectthat could happen when the methodExiled.Events.Patches.Events.Player.ChangingRoleAndSpawned.ChangeInventoryfor some reasonWhat is the current behavior?
The error trigger me >:(
What is the new behavior?
No more error (stonks!)
Does this PR introduce a breaking change?
Nop
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other