Updated CustomItems & CustomRoles give commands to use default RAUtils.ProcessPlayerIdOrNamesList #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis1706
requested changes
Nov 14, 2024
|
Also build your branch with Release not Debug because you wouldn't seen all the error to fix issue of compiling |
|
Alright. I'll do that as soon as I can. |
VALERA771
requested changes
Nov 15, 2024
louis1706
requested changes
Nov 15, 2024
louis1706
reviewed
Nov 16, 2024
louis1706
requested changes
Nov 18, 2024
Misfiy
requested changes
Nov 18, 2024
This reverts commit 410fb61.
louis1706
approved these changes
Nov 22, 2024
VALERA771
approved these changes
Nov 22, 2024
| @@ -18,6 +18,8 @@ namespace Exiled.CustomItems.Commands | |||
| using Exiled.Permissions.Extensions; | |||
|
|
|||
| using RemoteAdmin; | |||
| using UnityStandardAssets.Effects; | |||
Misfiy
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
What is the current behavior? (You can also link to an open issue here)
Commands currently evaluate only
*,all, orPlayer.IdWhat is the new behavior? (if this is a feature change)
Commands now evaluate players based on
RAUtils.ProcessPlayerIdOrNamesList(eg@player.17.15) as well as*,all, orPlayer.Id.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No breaking changes
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other