Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Exiled::Events] [Exiled::API] New event + new property #31

Merged
merged 9 commits into from
Nov 9, 2024
Merged

[Exiled::Events] [Exiled::API] New event + new property #31

merged 9 commits into from
Nov 9, 2024

Conversation

VALERA771
Copy link

@VALERA771 VALERA771 commented Aug 3, 2024 •
edited
Loading

Description

Describe the changes
Adding new event - Escaped.
Adding new property for player - PreviousRole (tested).

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

louis1706
louis1706 requested changes Aug 6, 2024
View reviewed changes
Copy link

@louis1706 louis1706 left a comment •
edited by VALERA771
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add EscapedEventArgs::SpawnableTeamType
Add EscapedEventArgs::NumberOfTicket
Add EscapedEventArgs::RoleType
Add EscapedEventArgs::EscapeTime

Also only for EscapeScenario don't take it from previous event but from the Ldloc_1 in case plugin or NWAPI change it's way to make this event to not interfere

@VALERA771
Copy link
Author

Add EscapedEventArgs::SpawnableTeamType

Add EscapedEventArgs::NumberOfTicket

Add EscapedEventArgs::RoleType

Add EscapedEventArgs::EscapeTime

Also only for EscapeScenario don't take it from previous event but from the Ldloc_1 in case plugin or NWAPI change it's way to make this event to not interfere

Technically, we can get RoleTypeId and SpawnableTeamType from Escape scenario
(Wtf I can edit messages from other users?!)

@louis1706
Copy link

Add EscapedEventArgs::SpawnableTeamType

Add EscapedEventArgs::NumberOfTicket

Add EscapedEventArgs::RoleType

Add EscapedEventArgs::EscapeTime

Also only for EscapeScenario don't take it from previous event but from the Ldloc_1 in case plugin or NWAPI change it's way to make this event to not interfere

Technically, we can get RoleTypeId and SpawnableTeamType from Escape scenario
(Wtf I can edit messages from other users?!)

Yeah that why i ask to add them :)

(Yes your devboy)

@VALERA771 VALERA771 requested review from louis1706 and Misfiy August 12, 2024 13:59
@VALERA771
suj
bddd7d3
@VALERA771
Merge remote-tracking branch 'upstream/dev' into escaped-event
e2f58c5 
# Conflicts:
#	EXILED/Exiled.Events/Patches/Events/Player/EscapingAndEscaped.cs
@VALERA771
fix
2147c94
@VALERA771 VALERA771 requested a review from louis1706 August 12, 2024 15:19
louis1706
louis1706 approved these changes Aug 12, 2024
View reviewed changes
Copy link

@louis1706 louis1706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If transpiller work it's fine

Jesus-QC
Jesus-QC requested changes Sep 23, 2024
View reviewed changes
EXILED/Exiled.API/Features/Player.cs Outdated Show resolved Hide resolved
@VALERA771 VALERA771 requested a review from Jesus-QC October 11, 2024 22:10
@VALERA771 VALERA771 merged commit 043d9a9 into ExMod-Team:dev Nov 9, 2024
5 checks passed
louis1706 added a commit to louis1706/EXILED that referenced this pull request Nov 17, 2024
@louis1706
Revert "[Exiled::Events] [Exiled::API] New event + new property (E…
d8fa348 
…xMod-Team#31)"

This reverts commit 043d9a9.
louis1706 added a commit that referenced this pull request Nov 17, 2024
@louis1706 @VALERA771
@Undid-Iridium @SrLicht
Nw documentation (#182)
f0174d3 
* `[Exiled::Events]` `[Exiled::API]` New event + new property (#31)

* new ev + previous role

* suggestions

* uwu

* suj

* fix

* uwu

---------

Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com>

* [EXILED::Events] BeingObserved event stolen (#91)

* Scp173 Observing, Stolen from https://github.com/ExMod-Team/EXILED/pull/72/files

* Remove old comment

* Fix Error

Co-Authored-By: SrLicht <cerberus.tk.sl@gmail.com>

* NW Documentation

* moving forward

* YES

* Fix

* Update

* Index Update

* Change Order

* OrderBy

* Revert "Fix Error"

This reverts commit d53d84d.

* Revert "[EXILED::Events] BeingObserved event stolen (#91)"

This reverts commit cc7c183.

* Revert "`[Exiled::Events]` `[Exiled::API]` New event + new property (#31)"

This reverts commit 043d9a9.

* remove using

* NW_Documentation

* SCPSLRessources NW doc

* Change

* try to fix labeller

try to fix labeler

* Update DamageHandler Doc

* Revert partially

This reverts commit 03122a3.

---------

Co-authored-by: VALERA771 <72030575+VALERA771@users.noreply.github.com>
Co-authored-by: X <24619207+Undid-Iridium@users.noreply.github.com>
Co-authored-by: SrLicht <cerberus.tk.sl@gmail.com>
@VALERA771 VALERA771 deleted the escaped-event branch December 20, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IRacle1 IRacle1 IRacle1 left review comments

@Misfiy Misfiy Misfiy approved these changes

@louis1706 louis1706 louis1706 approved these changes

@Jesus-QC Jesus-QC Awaiting requested review from Jesus-QC

Assignees

@VALERA771 VALERA771

Labels
API Events Transpiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VALERA771 @louis1706 @Jesus-QC @IRacle1 @Misfiy